On Mon, Feb 9, 2015 at 10:39 AM, Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> wrote: > On 02/09/2015 10:37 AM, Trond Myklebust wrote: >> On Mon, Feb 9, 2015 at 10:31 AM, Anna Schumaker >> <Anna.Schumaker@xxxxxxxxxx> wrote: >>> >>> Hi Trond, >>> >>> On 02/08/2015 10:07 PM, Trond Myklebust wrote: >>>> Now that we no longer use the partial shutdown code when closing the >>>> socket, we no longer need to worry about the TCP linger2 state. >>> >>> Can you also remove the "#define XS_TCP_LINGER_TO" and xs_tcp_fin_timeout from the top of xprtsock.c? It looks like they don't have any users after this patch. >>> >>> Thanks, >>> Anna >> >> >> Technically, those are part of the user ABI (being in the >> xs_tunables_table), so we should probably proceed with care before >> removing them. > > Okay. Maybe at least move xs_tcp_fin_timeout so it's under CONFIG_SUNRPC_DEBUG to match when the tunables_table is defined? > ACK. That makes perfect sense... -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
