On Wed, Feb 04, 2015 at 07:32:43AM -0500, Trond Myklebust wrote: > Delegations are all about allowing the NFS client to cache data > aggressively, and notifying when it is no longer safe to do so. That > is clearly not of interest to an application using O_DIRECT, since it > is by definition managing the data cache (if there is one) instead of > the NFS client. We don't share delegation state with userspace and > even if we did, there are no existing applications out there that are > capable (or even interested) of taking advantage of it. > > You can argue that the client could still use the delegation to cache > metadata and open/lock state, but most of the users of O_DIRECT of > which I'm aware tend to be data intensive, and not very metadata/state > intensive. So why burden both the server and the with that extra state > management? How does the delegation hurt us in this case? That needs to go into the patch description, and into a comment near the code. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html