On Sun, Jan 25, 2015 at 3:11 PM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: > > > On Jan 24, 2015, at 7:18 PM, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> wrote: > > > We should be safe now, as long as we don't do GFP_IO or higher allocations > > Should the GFP flags in xprt_rdma_allocate() reflect this change > as well? The non-swap case uses GFP_NOFS currently, and the GFP_NOFS or GFP_NOWAIT? If the former, then that would be yet further justification for PATCH 1/2. > swap case does not include GFP_MEMALLOC. These choices might be > out of date. > > If so I can submit a patch on top of my existing for-3.20 series > that changes xprt_rdma_allocate() to use the same flags as > rpc_malloc(). Yes. I think GFP_NOIO is the more conservative (and correct) approach here, rather than GFP_NOFS. In particular it means that we won't trigger any new swap-over-nfs activity. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
