Re: [PATCH v1 06/10] svcrdma: Plant reader function in struct svcxprt_rdma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/13/2015 4:05 AM, Sagi Grimberg wrote:
On 1/12/2015 6:45 PM, Steve Wise wrote:
On 1/12/2015 10:26 AM, Steve Wise wrote:

-----Original Message-----
From: Chuck Lever [mailto:chuck.lever@xxxxxxxxxx]
Sent: Monday, January 12, 2015 10:20 AM
To: Steve Wise
Cc: Sagi Grimberg; linux-rdma@xxxxxxxxxxxxxxx; Linux NFS Mailing List
Subject: Re: [PATCH v1 06/10] svcrdma: Plant reader function in
struct svcxprt_rdma


On Jan 12, 2015, at 11:08 AM, Steve Wise
<swise@xxxxxxxxxxxxxxxxxxxxx> wrote:


-----Original Message-----
From: Chuck Lever [mailto:chuck.lever@xxxxxxxxxx]
Sent: Sunday, January 11, 2015 6:41 PM
To: Sagi Grimberg; Steve Wise
Cc: linux-rdma@xxxxxxxxxxxxxxx; Linux NFS Mailing List
Subject: Re: [PATCH v1 06/10] svcrdma: Plant reader function in
struct svcxprt_rdma


On Jan 11, 2015, at 12:45 PM, Sagi Grimberg
<sagig@xxxxxxxxxxxxxxxxxx> wrote:

On 1/9/2015 9:22 PM, Chuck Lever wrote:
The RDMA reader function doesn't change once an svcxprt is
instantiated. Instead of checking sc_devcap during every incoming
RPC, set the reader function once when the connection is accepted.
General question(s),

Any specific reason why to use FRMR in the server side? And why only
for reads and not writes? Sorry if these are dumb questions...
Steve Wise presented patches a few months back to add FRMR, he
would have to answer this. Steve has a selection of iWARP adapters
and maybe could provide some idea of performance impact. I have
only CX-[23] here.

The rdma rpc server has always tried to use FRMR for rdma reads as
far as I recall.  The patch I submitted refactored the design
in
order to make it more efficient and to fix some bugs.   Unlike IB,
the iWARP  protocol only allows 1 target/sink SGE in an rdma
read
request message, so an FRMR is used to create that single
target/sink SGE allowing 1 read to be submitted instead of many.
How does this work when the client uses PHYSICAL memory registration?
Each page would require a separate rdma read WR.  That is why we use
FRMRs. :)

Correction, each physical scatter gather entry would require a separate
read WR.  There may be contiguous chunks of physical mem that can be
described with one RDMA SGE...


OK, thanks for clarifying that for me.

From the code, I think that FRMR is used also if the buffer can
fit in a single SGE. Wouldn't it be better to skip the Fastreg WR in
this case?


Perhaps.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux