On Fri, Jan 09, 2015 at 09:43:41AM -0800, Trond Myklebust wrote: > > [nfsv4] NFSv4.1 errata id 3226 (the return of return-on-close layouts) > > > > ...on thee nfsv4@xxxxxxxx mailing list. Trond mentions it there. > > Perhaps we need to revise that errata? > > > > Please see: > http://www.rfc-editor.org/errata_search.php?eid=3901 I think the language in this errata is very confusing, especially: "After the client has closed all open stateids and returned the delegation stateids for a file for which logr_return_on_close was set to TRUE, the server MUST invalidate all layout segments that were issued to the client for that file." While the idea that return on close layouts should be valid as long as the "parent" stateid is around make a lot of sense, this requirement to track all open / delegation stateids per file/client combination seems insane. The only logical way to extend the original text is to require layouts to be implicitly returned when: - the file is close for a layout stateid that is created based on the open or lock stateid - the delegation is returned for a layout stateid that is created based on the delegation stateid. That is, only keep layouts opened based on the delegation stateid alive over a close if they are hanging off that delegation stateid. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
