On Mon, Jan 05, 2015 at 03:31:46PM -0500, Weston Andros Adamson wrote: > These patches look good to me, but have you tested them? ;) > > I mean, does anyone have a server that implements SP4_MACH_CRED to test against? > When I originally developed this feature, I tested against a hacked nfsd… > that code was really ugly (not ready for upstreaming), but allowed me to test the client > feature. > > IRRC the server side is difficult because the server has to keep stateid to credential > mappings, so when the machine cred was used it could check access against the acting cred. > > If there aren’t any servers to test this against, maybe we remove this feature? It can always > be revived once there is a server to test against. The Linux server should support MACH_CRED as of 57266a6e916e2522ea61758a3ee5576b60156791 "nfsd4: implement minimal SP4_MACH_CRED". (Well, plus some later bugfixes.) But I think anything since 3.14 should be OK. That said, I wouldn't be surprised if it has problems. But please do test against that and let me know.... --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
