Hi Frank, On Sun, Dec 21, 2014 at 6:40 AM, Frank van Maarseveen <frankvm@xxxxxxxxxxx> wrote: > While updating the nfs-ngroups patch for 3.17 and 3.18 I noticed that > nfs_permission() seems to be missing a put_rpccred() call in the non > -ECHILD path. I fully agree that it is confusing, but the current code is actually correct. Please see the changelog for commit bd95608053b7f (sunrpc/auth: allow lockless (rcu) lookup of credential cache.) which explains the rules for the RCU-safe credential lookup. We definitely do want to document this behaviour a little better in the source. Any takers? Cheers, Trond -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
