On Wed, Dec 17, 2014 at 5:03 AM, Anna Schumaker
<Anna.Schumaker@xxxxxxxxxx> wrote:
> On 12/16/2014 02:01 PM, Tom Haynes wrote:
>> From: Peng Tao <tao.peng@xxxxxxxxxxxxxxx>
>>
>> So that we can detect the case if some layout segments are still
>> pinned which is surely a bug that we need to fix.
>
> How often is this hit? A patch fixing the bug would be better than a patch just to detect it :).
>
Never yet :)
I was suspecting a bug in segment reference counting and thus added
the patch. That bug turns out to be somewhere else but I thought the
WARN makes sense in general sense because without it we silently
ignores unfreed reference counts.
Cheers,
Tao
> Anna
>
>>
>> Signed-off-by: Peng Tao <tao.peng@xxxxxxxxxxxxxxx>
>> ---
>> fs/nfs/pnfs.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
>> index 5f7c422..e123cfc 100644
>> --- a/fs/nfs/pnfs.c
>> +++ b/fs/nfs/pnfs.c
>> @@ -242,6 +242,8 @@ pnfs_put_layout_hdr(struct pnfs_layout_hdr *lo)
>> struct inode *inode = lo->plh_inode;
>>
>> if (atomic_dec_and_lock(&lo->plh_refcount, &inode->i_lock)) {
>> + if (!list_empty(&lo->plh_segs))
>> + WARN_ONCE(1, "NFS: BUG unfreed layout segments.\n");
>> pnfs_detach_layout_hdr(lo);
>> spin_unlock(&inode->i_lock);
>> pnfs_free_layout_hdr(lo);
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
