Re: [PATCH 1/1] nfsd/exportfs: allow empty exports file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



steved> The presidence has been set that having an empty
steved> export file is not a problem. So I would rather
steved> change that xlog to be a L_WARNING and only log it
steved> when the verbose is set.

The situation, PRECEDENCE, when I got involved was:
  no entries in exports:
    nothing logged, nfsd started
  all good entries in exports
    nothing logged, nfsd started
  mixture of bad and good entries in exports
    bad entries logged, error logged, nfsd aborted
  all bad entries in exports
    bad entries logged, error logged, nfsd aborted

My first patch overlooked that first condition, and made the
situation like below, changed from PRECEDENCE uppercased:
  no entries in exports:
    EMPTY LOGGED, NFSD ABORTED
  all good entries in exports
    nothing logged, nfsd started
  mixture of bad and good entries in exports
    bad entries logged, NFSD STARTED
  all bad entries in exports
    bad entries logged, error logged, nfsd aborted

Current patch makes it, changes from PRECEDENCE uppercased:
  no entries in exports:
    nothing logged, nfsd started
  all good entries in exports
    nothing logged, nfsd started
  mixture of bad and good entries in exports
    bad entries logged, NFSD STARTED
  all bad entries in exports
    bad entries logged, error logged, nfsd aborted

Your patch makes it, changes from PRECEDENCE uppercased:
  no entries in exports:
    WARNING LOGGED, nfsd started
  all good entries in exports
    nothing logged, nfsd started
  mixture of bad and good entries in exports
    bad entries logged, NFSD STARTED
  all bad entries in exports
    bad entries logged, NFSD STARTED

Your pick,

-- Henrique
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux