> On Nov 13, 2014, at 6:02 AM, Christoph Hellwig <hch@xxxxxx> wrote: > > On Thu, Nov 13, 2014 at 09:03:53AM +0800, Peng Tao wrote: >>> but should be contiguous (as enforced by nfs_flush_incompatible). >>> >> The idea is to get an estimation on the length of layout that client >> wants to use. So even if a single byte is used by client, client would >> want to ask for a layout that covers the whole page. > > That code is very non-obvious and could use a few more comments. > > I think the NFS_I(inode)->npages should be replaced with > inode->i_mapping->nrpages which counts the number of page cache pages. That sounds reasonable. Can someone track this down? I don’t have a block server to test against… Thanks for the help Tao and Christoph! -dros-- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
