On Wed, Nov 5, 2014 at 2:42 PM, Jeff Layton <jeff.layton@xxxxxxxxxxxxxxx> wrote: > On Wed, 5 Nov 2014 13:31:52 -0500 > "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: >> Oops, right, except for the case where the delegation's revoked just >> because the client ran out of time doing the recall. In which case I >> think the final error's going to be either EXPIRED (4.0) or >> DELEG_REVOKED (4.1)? (Except I think the Linux server's returning >> BAD_STATEID in the 4.0 case, which looks wrong.) >> > > I'm not sure that that's right... RFC3530 says: > > NFS4ERR_EXPIRED A lease has expired that is being used in the > current operation. > > ...implicit in the scenario I layed out above is that the lease is > being maintained. It's just that the client failed to return the > delegation in time. So, BAD_STATEID may be correct, actually? NFS4ERR_ADMIN_REVOKED is the expected error, but that requires the server to keep the stateid around for a while (which is why NFSv4.1 added the FREE_STATEID requirement). NFS4ERR_BAD_STATEID will work in a pinch... -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html