On Oct 20, 2014, at 9:57 AM, Will Deacon <will.deacon@xxxxxxx> wrote: > On Sat, Oct 11, 2014 at 02:32:29PM +0100, Weston Andros Adamson wrote: >> Hey Will, > > Hi again, Andros, > >> I’ve been very busy, but I haven’t forgotten about your bug report! > > No problem, I've been busy too. I just checked with -rc1 and I can reproduce > the issue there too. > >> I think the WARN_ON_ONCE is just wrong, there are cases where the >> PG_INODE_REF flag is legitimately not set. The flag is set so that sub >> requests can mimmic the parent request’s reference count. >> >> Could you please run the reproducer again, unmount, then check the contents of >> /proc/fs/nfsfs/servers? > > Sure. I just tried this and that file is empty after unmounting. Sorry for the delay (again) - I just got back from a two week holiday. This is good news! I think we can safely remove this WARN_ON_ONCE and call it a day… or maybe calling it a month is more accurate ;) -dros -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html