On Thu, Oct 30, 2014 at 02:03:06AM -0700, Christoph Hellwig wrote: > On Tue, Oct 28, 2014 at 09:16:10PM +0800, Eryu Guan wrote: > > >From nfs(5) we can know that atime related mount options have no effect > > on NFS mounts, so add _require_atime() helper to skip atime tests on NFS > > I' like to use this opportunity to start a discussion on NFS atime > handlign again, which I think is broken. I think relatime is perfectly > fine default semantics for NFS, and not supporting it can cause all > kidns of application breakage. Supporting normal atime semantics when > explicity requested is also something NFS shouldn't sneak out of. > > > Also change the way how _require_relatime() mount $SCRATCH_DEV, use > > _scratch_mount helper so it's mounted with selinux context, to avoid > > "same superblock, different selinux context" failure. > > Can you please split this part into a separate patch? > Sure, will do in v2. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html