Re: [PATCH v2] NFS: SEEK is an NFS v4.2 feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 22, 2014 at 03:53:10PM -0400, Anna Schumaker wrote:
> Somehow the nfs_v4_1_minor_ops had the NFS_CAP_SEEK flag set, enabling
> SEEK over v4.1.  This is wrong, and can make servers crash.
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>

Thanks!

Tested-by: J. Bruce Fields <bfields@xxxxxxxxxx>

--b.

> ---
> v2: Fix compile error
> 
>  fs/nfs/nfs4proc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 405bd95..8aba549 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -8408,8 +8408,7 @@ static const struct nfs4_minor_version_ops nfs_v4_1_minor_ops = {
>  		| NFS_CAP_CHANGE_ATTR
>  		| NFS_CAP_POSIX_LOCK
>  		| NFS_CAP_STATEID_NFSV41
> -		| NFS_CAP_ATOMIC_OPEN_V1
> -		| NFS_CAP_SEEK,
> +		| NFS_CAP_ATOMIC_OPEN_V1,
>  	.init_client = nfs41_init_client,
>  	.shutdown_client = nfs41_shutdown_client,
>  	.match_stateid = nfs41_match_stateid,
> @@ -8431,7 +8430,8 @@ static const struct nfs4_minor_version_ops nfs_v4_2_minor_ops = {
>  		| NFS_CAP_CHANGE_ATTR
>  		| NFS_CAP_POSIX_LOCK
>  		| NFS_CAP_STATEID_NFSV41
> -		| NFS_CAP_ATOMIC_OPEN_V1,
> +		| NFS_CAP_ATOMIC_OPEN_V1
> +		| NFS_CAP_SEEK,
>  	.init_client = nfs41_init_client,
>  	.shutdown_client = nfs41_shutdown_client,
>  	.match_stateid = nfs41_match_stateid,
> -- 
> 2.1.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux