On 10/22/14 15:22, J. Bruce Fields wrote: > On Tue, Oct 21, 2014 at 09:14:06AM -0400, J. Bruce Fields wrote: >> Also my tests are failing due to an unrelated crash in 18-rc1 which I >> want to track down before sending this in. > > There are two bugs: > > - the client is sending SEEK over minorversion 1. > - this sometimes causes the server to crash. > > I'm testing a fix for the latter. > > On the former: looks like if 4.2 support is built in, then llseek is set > to nfs4_file_llseek, which unconditionally calls nfs42_proc_llseek(). > > Does nfs4_file_llseek need an explicit minorversion check, or should it > be handled some other way? The client should be checking for CAP_SEEK, which should only be set on NFS v4.2. I'll look into this! > > --b. > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
