Re: xfstests and linux nfs testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/09/14 12:21, Christoph Hellwig wrote:
> On Thu, Oct 09, 2014 at 08:41:54AM -0400, Anna Schumaker wrote:
>> I think this is a bug in xfstests.  This fixes it for me, but I'm not sure what needs to be checked in the NFS case:
> 
> Lukas broke this with:
>  common: Check fs consistency on TEST_DEV only when needed
> 
> as far as I can tell it blindly copied the _require_scratch code
> to _require_test, which is bad for two reasons:
> 
>  a) due to lots of code duplication
>  b) because it broke filesystems that don't support a scratch dev
>     like nfs.
> 
> Anna fix should work, can you resend it to the fstests lists with a
> proper signoff?  Even better would be some validation that the
> passed in "device" is a valid format for a nfs export, but that's not
> strictly required.

Sure!  I'll fix up the patch so it doesn't have commented out lines while I'm at it :).  I'll take a stab at server format validation, and then send something out!

Anna
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux