On Tue, Oct 07, 2014 at 10:59:47AM -0700, Thomas Haynes wrote: > From: Tom Haynes <loghyr@xxxxxxxxxxxxxxx> > > Callers of pnfs_put_lseg_async() might encounter no writes to > be committed, etc. As such, do not attempt to add work if none > is needed. Also, don't oops if that is the case. I think that last issue is the main culprit, isn't it? :) I still think adding the NULL check to filelayout_clear_request_commit would be more reasonable, as it's clear that freeme can be NULL there, but as pnfs_put_lseg accepts a NULL lseg it's probably wise to keep the two in sync. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
