Re: [PATCH V3] svcrdma: advertise the correct max payload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 24, 2014, at 4:55 AM, Sagi Grimberg <sagig@xxxxxxxxxxxxxxxxxx> wrote:

> On 9/24/2014 1:11 AM, Steve Wise wrote:
>> Svcrdma currently advertises 1MB, which is too large.  The correct value
>> is the minimum of RPCSVC_MAXPAYLOAD and the max scatter-gather allowed
>> in an NFSRDMA IO chunk * the host page size. This bug is usually benign
>> because the Linux X64 NFSRDMA client correctly limits the payload size to
>> the correct value (64*4096 = 256KB).  But if the Linux client is PPC64
>> with a 64KB page size, then the client will indeed use a payload size
>> that will overflow the server.
>> 
> 
> Maybe I'm a bit late with this, but can you explain why SG table is
> limited to 64 (fastreg MR and page_list probably bound it). Where is it
> coming from? Naturally it needs to be bound by some figure, but why 64?

It’s arbitrary, AFAIK. It has been used to allocate some data structures
on the stack, for example, so it can’t be too large.

It’s something we need to look at.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com



--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux