On Wed, Sep 24, 2014 at 11:29:54AM -0400, Jeff Layton wrote: > > Split out initializing the nfs4_callback structure from using it. For > > the NULL callback this gets rid of tons of pointless re-initializations. > > > > Note that I don't quite understand what protects us from running multiple > > NULL callbacks at the same time, but at least this chance doesn't make > > it worse.. > > > > Doesn't the workqueue ensure that? Or am I misunderstanding what you're > saying there? For the code after my patch that is indeed the case, but before my patch we'd re-initialize various fields in cl_cb_null everytime do_probe_callback gets called. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
