On 09/22/2014 06:34 PM, J. Bruce Fields wrote: > On Mon, Sep 22, 2014 at 05:14:05PM -0400, Steve Dickson wrote: >> >> >> On 09/22/2014 04:44 PM, J. Bruce Fields wrote: >>> On Mon, Sep 22, 2014 at 03:43:09PM -0400, Steve Dickson wrote: >>>> >>>> >>>> On 09/22/2014 03:26 PM, Simo Sorce wrote: >>>>> On Mon, 22 Sep 2014 15:20:07 -0400 >>>>> Steve Dickson <steved@xxxxxxxxxx> wrote: >>>>> >>>>>> Added the gssproxy.service to both the Wants= and >>>>>> Atfers= lines, before the rpc-svcgssd.service. There >>>>>> are ConditionPathExists= lines in the rpc-svcgssd.service >>>>>> unit which will stop the rpc.svcgssd daemon from >>>>>> starting when the gssproxy daemon is already running. >>>>>> >>>>>> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx> >>>>>> --- >>>>>> systemd/nfs-server.service | 5 +++-- >>>>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service >>>>>> index 2fa7387..c740fa2 100644 >>>>>> --- a/systemd/nfs-server.service >>>>>> +++ b/systemd/nfs-server.service >>>>>> @@ -2,12 +2,13 @@ >>>>>> Description=NFS server and services >>>>>> Requires= network.target proc-fs-nfsd.mount rpcbind.target >>>>>> Requires= nfs-mountd.service >>>>>> -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service >>>>>> rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service >>>>>> +Wants=rpc-gssd.service >>>>>> Wants=rpc-statd-notify.service >>>>>> >>>>>> After= network.target proc-fs-nfsd.mount rpcbind.target >>>>>> nfs-mountd.service After= nfs-idmapd.service rpc-statd.service >>>>>> -After= rpc-gssd.service rpc-svcgssd.service >>>>>> +After= rpc-gssd.service gssproxy.service rpc-svcgssd.service >>>>>> Before= rpc-statd-notify.service >>>>>> >>>>>> Wants=nfs-config.service >>>>> >>>>> I think you really need to insure that the modules are loaded before >>>>> any of the server services are started, perhaps adding a unit file that >>>>> exec's modprobe and has "Before: gssproxy.service rpc-svcgssd.service" >>>>> in it ? >>>> I really don't think its needed... From my testing it appears >>>> gssproxy is always being started and rpc.svcgssd is not... >>> >>> Huh. Well rpc-svcgssd.service has var-lib-nfs-rpc_pipefs.mount as both >>> "Requires=" and "After=", so rpc-svcgssd.service will never run >>> without first running var-lib-nfs-rpc_pipefs.mount, which will load >>> sunrpc. But I don't see where auth_rpcgss is getting loaded. And I >>> don't see what ensures anything happening before gssproxy runs. >> It happens during the mount on the client and when the server >> is started. >> >>> >>> We want to make sure your testing's not just getting lucky on the >>> startup order. >> The reason it working is because rpc.gssd is being started on the server >> these days for callbacks and the After= line in rpc-svcgssd.service is being >> executed before the ConditionPathExists which cause rpc.svcgssd not to start. > > nfs-utils$ grep After systemd/rpc-svcgssd.service > After=var-lib-nfs-rpc_pipefs.mount > After=gssproxy.service > After=nfs-config.service > > There doesn't seem to be an After= line referring to rpc.gssd. No, why should there be? There is After= line referring to rpc.gssd in nfs-server.service grep After systemd/nfs-server.service After= network.target proc-fs-nfsd.mount rpcbind.target nfs-mountd.service After= nfs-idmapd.service rpc-statd.service After= rpc-gssd.service rpc-svcgssd.service After=nfs-config.service So when the server starts,rpc.gssd will start and rpc.svcgssd will start if gssproxy is not enable and there is a key tab. > >> So when gssproxy.service does it's "Before=nfs-secure.service nfs-secure-server.service" >> line everything is loaded before gssproxy start... > > That line only makes gss-proxy start before those other things. Right, which will load the sunrpc modules. > >> I'm think gssproxy.service just needs to the put the Wants and After= >> var-lib-nfs-rpc_pipefs.mount lines, instead of that Before line.. > > That would make sure sunrpc's loaded, but not auth_rpcgss. On the client side the mount -o sec=krb5? loads auth_rpcgss module. Maybe the loading of nfsd loads the module? But I don't think that module has to be loaded for any of the gss daemons (gssd, svcgssd or gssproxy) to start successfully... > >>>> Plus, from my understanding... loading module from a service >>>> file is a big no no! People were having problems with >>>> way back when... >>> >>> Any pointers? Google's not finding me anything. >> Search the the Fedora bz's when systemd first came out... > > All I can find is: > > https://bugzilla.redhat.com/show_bug.cgi?id=699040#c16 > > Btw afaik modules should be loaded via autoloading based on bus > information, or via /etc/modules-load.d/*.conf. and unloading a > module from the kernel should not be done except for debugging > purposes so loading all these modules is it really necessary? > > Which I agree with--modules should normally load on demand when we need > them, and we should have an explanation for exceptions. Yes, this was the conversation I was referring to.. Thank you for digging it out.. > > But here we have a pretty reasonable explanation (we need to know > on startup whether a certain module has a certain feature, and we have > to modprobe to do that). I don't see any blanket prohibition against > loading modules. Lets talk with the systemd people to see what they say... steved. > > OK, and in 702707 there's a request for support of the monolithic kernel > case, but that's easy, we just allow the modprobe to fail in that case. > > --b. > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
