----- "Christoph Hellwig" <hch@xxxxxx> wrote: > On Mon, Sep 15, 2014 at 12:05:55PM +0300, Boaz Harrosh wrote: > > I do not understand. This used to work just fine. Please point me > to > > the patch that broke it? > > (And since when are we allowed to brake old code?) > > I bet it still works the same way it does as commited, which doesn't > make it right. The way the NFS XDR buffer allocations work seems to > be > that you can actually slightly overun it without things falling > apart, > but that doesn't make it right. E.g. it took a fairly larger overrun > in the block layout driver to finally find the issues, and most of > the > time it was just silent truncations, real corruption happened less > often. > > But to make sure things work properly in the long run you'd really > want > to have the proper allocation. This is probably the case, then. The object layout layoutupdate is only 16 bytes long and is fixed size, so it wouldn't take much extra space for it to never hit. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
