On 09/13/2014 03:05 AM, Timo Teras wrote: > On Fri, 12 Sep 2014 13:00:00 -0400 > Steve Dickson <SteveD@xxxxxxxxxx> wrote: > >> Hello, >> >> On 08/08/2014 02:11 AM, Timo Teräs wrote: >>> The kernel support only access by read() and write() with exactly >>> one line in the buffer. FILE can be implemented with readv() and >>> writev(), and the mapping to syscalls is not guaranteed. The code >>> already does lot of extra work setvbuf() and fflush() calls to try >>> to ensure this, but it relays on implementation details and is >>> non-portable. And e.g. with musl library the current hacks do not >>> work at all. >>> >>> Remove the FILE based qword_* API as it's fundamentally broken, >>> and replace it with explicitly caching one line at a time. The >>> qword API should probable improved to do the line caching >>> internally, and this is the first step towards that. >>> >>> Signed-off-by: Timo Teräs <timo.teras@xxxxxx> >>> --- >>> This along with Natanael Copa's patchset makes nfs-utils somewhat >>> usable with musl c-library. >> First of all, I apologize for taking so long to get this patch. >> >> Second of all, I'm going to NAK this patch because it breaks v3 >> mounts. (Note: this patch was applied after Natanael patchset). >> >> Using a Fedora 20 server, Fedora 20 clients fail with >> mount.nfs: Unknown error 521 >> and Fedora 21 clients fail with >> mount.nfs: an incorrect mount option was specified > > Thanks for the testing and feedback. We had issues with nfs3 on musl > too and were uncertain if our broke something, or if it's just > something additional to be fixed. > > Did you test Natanaels patch set individually first? I'm wonderinf > which patch set breaks nfs3. Yes, I simply remove this patch and v3 started working again. > >> Also the following warnings occur after the patch is applied: >> >> cache.c:128:21: warning: ignoring return value of 'write', declared >> with attribute warn_unused_result [-Wunused-result] cache.c:1495:21: >> warning: ignoring return value of 'write', declared with attribute >> warn_unused_result [-Wunused-result] nfssvc.c:71:8: warning: ignoring >> return value of 'system', declared with attribute warn_unused_result >> [-Wunused-result] nfssvc.c:325:9: warning: ignoring return value of >> 'write', declared with attribute warn_unused_result [-Wunused-result] > > My patch seems introduce few of these, but I think some of this come > from Natanaels patch set. I didn't see them after I remove your patch.... > >> My suggestion is to break the patch up into several small patches >> which would help with debugging the problem. > > Yes. Might be a good idea. > >> I'll be more than willing to reconsider this change when it >> stop braking v3 mounts and there are no warnings. > > Thanks for review, testing and feedback. > np... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
