On 09/09/2014 11:55 AM, Christoph Hellwig wrote: > On Tue, Sep 09, 2014 at 10:49:41AM -0400, Anna.Schumaker@xxxxxxxxxx wrote: >> From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> >> >> The ALLOCATE operation is used to preallocate space in a file. I use >> vfs_fallocate() to do the actual preallocation. >> >> Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> > > Looks largely good, but can you do an audit how the error codes match > the spec? E.g. We return -ENODEV in do_fallocate if it's called on > a special file, but that doesn't translate to any valid error codes > for ALLOCATE in the NFSv4.2. Good idea, I'll look into it! Anna > > I guess it should be NFSERR_NOTSUPP, and I'll work with Tom to actually > define this case in the spec. > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
