On Mon, Sep 8, 2014 at 10:49 PM, Christoph Hellwig <hch@xxxxxx> wrote: > On Mon, Sep 08, 2014 at 05:37:42PM -0700, Trond Myklebust wrote: >> Why wouldn't it make more sense to call pnfs_layoutcommit_inode() >> unconditionally before the call to pnfs_mark_matching_lsegs_invalid()? > > It would minimally reduce the latency, but otherwise be not very different. > The downside is that we'll now need two i_lock roundtrips per recall. > > But if this is your preference I can easily fix it up. Please do. It would make the code a little easier on the eye. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
