On Mon, Sep 8, 2014 at 4:54 PM, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> wrote: > On Wed, Aug 27, 2014 at 6:41 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: >> On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: >>> Cong Wang <xiyou.wangcong@xxxxxxxxx> writes: >>> >>> > I saw the following kernel warning: >>> >>> Cong thanks for finding and tracking this. I was clearly asleep at the >>> switch when I was testing my fix to the nfs client code :( >>> >>> I have applied this patch and will push it to Linus after it has a >>> little bit to sit in linux-next. >> >> Why does that code wank with one-by-one remove_proc_entry(), BTW? >> remove_proc_subtree("nfsfs", net->proc_net) will take care of the whole pile >> just fine, TYVM... While we are it, there's no need to keep ->proc_nfsfs >> at all - just have it in a local variable in nfs_fs_proc_net_init(). > > Since nobody sent me an updated version with the remove_proc_subtree > fix, I went ahead and edited the patch myself (see attachment). Cong, > please let me know if you disagree with that change, otherwise, that > will be the final patch sent upstream and Cc: stable # 3.4+. > > I'll schedule cleanup patches to make the same changes to the original > nfs_fs_proc_exit() and nfs_fs_proc_init() and to remove (struct > nfs_net)->proc_nfsfs for merging in 3.18. > Oops, I missed Al's reply and didn't know remove_proc_subtree() either. Thanks for the update and it definitely looks good to me! -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html