On Thu, Aug 21, 2014 at 11:31:24AM -0400, Trond Myklebust wrote: > We shouldn't need to set attr->ia_ctime/ia_mtime above. We should set > the file time to the server clock time. True. > Also note that instead of checking attr->ia_size != > i_size_read(inode), the above should check attr->ia_valid & ATTR_SIZE > due to the optimisation above. Or we could just make it an if/else clause. I'll send out an updated patch ASAP. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html