[PATCH] NFS: Fix state owner lock usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The function can_open_cached() is used to determine if we can open a file
using cached information.  It does this by reading values from the state
structure, which I think means we need to be holding the so_lock to get the
right answer.  The current code calls this function twice - once without the
lock, and then a second time with the lock to check the answer.  I think
this is technically correct, since false positives are verified and false
negatives lead to the normal open code.

Even if the code is correct, it's not immediately obvious to me why it works
so I think it's worth taking a second look at.

What do you all think?

Anna


Anna Schumaker (1):
  NFS: Clear up state owner lock usage

 fs/nfs/nfs4proc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux