On 9/2/2014 23:57, Christoph Hellwig wrote:
>> + file = dentry_open(&path, flags, current_cred());
>> + if (IS_ERR(file)) {
>> + host_err = PTR_ERR(file);
>> } else {
>
> The is_err case should have a
>
> goto out_nfserr;
>
> which would allow you to drop the following indentation if you
> change the whole function anyway.
>
>> if (may_flags & NFSD_MAY_64BIT_COOKIE)
>> - (*filp)->f_mode |= FMODE_64BITHASH;
>> + (file)->f_mode |= FMODE_64BITHASH;
>> else
>> - (*filp)->f_mode |= FMODE_32BITHASH;
>> + (file)->f_mode |= FMODE_32BITHASH;
>
> no need for the braces around file here.
>
Thanks for your review.
A new version of this patch has be sent.
thanks,
Kinglong Mee
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
