Re: [PATCH 1/2] lockd: Do not start the lockd thread before we've set nlmsvc_rqst->rq_task

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue,  2 Sep 2014 13:58:57 -0400
Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> wrote:

> This fixes an Oopsable race when starting lockd.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> ---
>  fs/lockd/svc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 673668a9eec1..c35cd43a06e6 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -306,7 +306,7 @@ static int lockd_start_svc(struct svc_serv *serv)
>  	svc_sock_update_bufs(serv);
>  	serv->sv_maxconn = nlm_max_connections;
>  
> -	nlmsvc_task = kthread_run(lockd, nlmsvc_rqst, "%s", serv->sv_name);
> +	nlmsvc_task = kthread_create(lockd, nlmsvc_rqst, "%s", serv->sv_name);
>  	if (IS_ERR(nlmsvc_task)) {
>  		error = PTR_ERR(nlmsvc_task);
>  		printk(KERN_WARNING
> @@ -314,6 +314,7 @@ static int lockd_start_svc(struct svc_serv *serv)
>  		goto out_task;
>  	}
>  	nlmsvc_rqst->rq_task = nlmsvc_task;
> +	wake_up_process(nlmsvc_task);
>  
>  	dprintk("lockd_up: service started\n");
>  	return 0;


Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux