On 08/27/2014 01:43 PM, Christoph Hellwig wrote: > On Wed, Aug 27, 2014 at 11:18:49AM -0400, Anna Schumaker wrote: >> This patch adds support for the NFS v4.2 operation SEEK. >> >> I think nfs4proc.c and nfs4xdr.c have grown out of control, and I would like >> to avoid adding new functions to these files unless absolutely necessary. >> Therefore, I created nfs4.2proc.c and nfs4.2xdr.h in an attempt to separate >> out the new code. >> >> Questions? Comments? Thoughts? > I hate the dot in the name :) why not nfs42proc.c and co? Sure, I can change that. I put the dot because I kept reading it "fourty-two" and now "four two". > > Also without splitting out the much larger 4.1 ops this seems a bit > pointless, although I generally like the idea. Oh, but I want to split those out too :D. I figured it would be easiest to come up with a solution now, when we're adding a new minor version, and then split out v4.1 once we know what we're doing. Anna > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html