This survived a full day of running trinity on one system and a full day of various iozone / fio on another. It’s good to go from my perspective. -dros On Aug 14, 2014, at 5:39 PM, Weston Andros Adamson <dros@xxxxxxxxxxxxxxx> wrote: > This patchset fixes a few issues with the creation of nfs_pageio_descriptor > page vectors, which are passed to nfs_pgio_header structures. > > These were first found by Toralf Förster <toralf.foerster@xxxxxx> by running > trinity, but I've since received a report of a real world usecase that > hit a related issue: kvm with cache=none. > > There are two problems that are closely related and seem to only be triggered > by direct i/o writev()/readv() calls. > > The fixes are: > - do not coalesce pages unless they are contiguous in file position *and* > within / betwen pages. > > - do not allow duplicated pages in the pagevector > > > I'm still testing these, but I thought I'd share what I have with the list. > > -dros > > Weston Andros Adamson (2): > nfs: disallow duplicate pages in pgio page vectors > nfs: can_coalesce_requests must enforce contiguity > > fs/nfs/pagelist.c | 30 +++++++++++++++++++++++++++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > > -- > 1.8.5.2 (Apple Git-48) > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
