On Sat, Aug 09, 2014 at 02:44:00PM +0100, Ross Lagerwall wrote:
> When creating a file that already exists in a read-only directory with
> O_EXCL, the NFSv3 server returns EACCES rather than EEXIST (which local
> files and the NFSv4 server return). Fix this by checking the MAY_CREATE
> permission only if the file does not exist. Since this already happens
> in do_nfsd_create, the check in nfsd3_proc_create can simply be removed.
Thanks.
>From a look at the history I believe the server has behaved this way
since the beginning. Is this creating a practical problem for you? How
did you notice it?
Inclined to apply it just for consistency as you suggest. And because
it removes some unnecessary code. But as a low priority: for 3.18 and
not stable.
--b.
>
> Signed-off-by: Ross Lagerwall <rosslagerwall@xxxxxxxxx>
> ---
> fs/nfsd/nfs3proc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
> index 4012899..8ebd4ac 100644
> --- a/fs/nfsd/nfs3proc.c
> +++ b/fs/nfsd/nfs3proc.c
> @@ -227,11 +227,6 @@ nfsd3_proc_create(struct svc_rqst *rqstp, struct nfsd3_createargs *argp,
> newfhp = fh_init(&resp->fh, NFS3_FHSIZE);
> attr = &argp->attrs;
>
> - /* Get the directory inode */
> - nfserr = fh_verify(rqstp, dirfhp, S_IFDIR, NFSD_MAY_CREATE);
> - if (nfserr)
> - RETURN_STATUS(nfserr);
> -
> /* Unfudge the mode bits */
> attr->ia_mode &= ~S_IFMT;
> if (!(attr->ia_valid & ATTR_MODE)) {
> --
> 2.0.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
