On Thu, 07 Aug 2014 08:15:01 -0400
Steve Dickson <SteveD@xxxxxxxxxx> wrote:
>
>
> On 07/30/2014 07:23 AM, Natanael Copa wrote:
> > We should not depend on the libc do free(3) on ai_canonname as that is
> > completely up to implementation and known o break things on uclibc and
> > musl libc.
> >
> > Signed-off-by: Natanael Copa <ncopa@xxxxxxxxxxxxxxx>
> > ---
> > support/export/hostname.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/support/export/hostname.c b/support/export/hostname.c
> > index d9153e1..30584b4 100644
> > --- a/support/export/hostname.c
> > +++ b/support/export/hostname.c
> > @@ -382,6 +382,7 @@ host_numeric_addrinfo(const struct sockaddr *sap)
> >
> > ai = host_pton(buf);
> >
> > +#if !definded(__UCLIBC__) && defined(__GLIBC__)
> You still have this typo here... and the only reason
> it compiled is HAVE_GETNAMEINFO is not defined
> in your world....
I do have HAVE_GETNAMEINFO or I wouldn't have this issue in first place.
$ grep HAVE_GETNAMEINFO support/include/config.h
#define HAVE_GETNAMEINFO 1
> How well were these change tested against glibc? I'm
> concern about eliminating chunks of need code with
> all these new defines....
Argh! Sorry my bad. I fixed but must missed it in a redo.
I have not tested those in glibc at all.
When I look now, this is wrong anyway. It was supposed to fix a
segfault due to a just-in-case free() below:
/*
* getaddrinfo(AI_NUMERICHOST) never fills in ai_canonname
*/
if (ai != NULL) {
free(ai->ai_canonname); /* just in case */
ai->ai_canonname = strdup(buf);
if (ai->ai_canonname == NULL) {
freeaddrinfo(ai);
ai = NULL;
}
}
I but I think my patch does the ifdef in wrong place. When I grep for
'never fills' in the sources i find that there are 2 places where there
is an
ai->ai_canonname = strdup(buf);
With the assumption that freeaddrinfo() will free ai->ai_canonname for
us. I think this is wrong.
The just in case free(ai->ai_canonname) causes segfault on uclibc (and
used to do so on musl too) and I am pretty sure the "ai->ai_canonname =
strdup(buf);" will cause memleak, atleast on musl libc.
I'd be happy if you applied the other 10 patches though.
Do you want me to resend the others 10 with a v3 prefix?
-nc
> steved.
>
> > /*
> > * getaddrinfo(AI_NUMERICHOST) never fills in ai_canonname
> > */
> > @@ -392,7 +393,9 @@ host_numeric_addrinfo(const struct sockaddr *sap)
> > ai = NULL;
> > }
> > }
> > +#endif
> >
> > return ai;
> > }
> > +
> > #endif /* !HAVE_GETNAMEINFO */
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
