Re: [PATCH v3 21/38] nfsd: Add reference counting to state owners

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 29, 2014 at 09:34:26PM -0400, Jeff Layton wrote:
>  struct nfs4_stateowner {
> -	struct list_head        so_strhash;   /* hash by op_name */
> -	struct list_head        so_stateids;
> -	struct nfs4_client *    so_client;
> +	struct list_head			so_strhash;
> +	struct list_head			so_stateids;
> +	struct nfs4_client			*so_client;
> +	const struct nfs4_stateowner_operations	*so_ops;
>  	/* after increment in ENCODE_SEQID_OP_TAIL, represents the next
>  	 * sequence id expected from the client: */

Uh, that could use updating--applying below.

Anyway, the stateowner reference counting makes sense to me.

--b.

commit 84a46922ea90
Author: J. Bruce Fields <bfields@xxxxxxxxxx>
Date:   Thu Jul 31 16:10:08 2014 -0400

    nfsd4: fix out of date comment
    
    Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>

diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
index 73a209dc352b..0b234500f104 100644
--- a/fs/nfsd/state.h
+++ b/fs/nfsd/state.h
@@ -345,7 +345,7 @@ struct nfs4_stateowner {
 	struct list_head			so_stateids;
 	struct nfs4_client			*so_client;
 	const struct nfs4_stateowner_operations	*so_ops;
-	/* after increment in ENCODE_SEQID_OP_TAIL, represents the next
+	/* after increment in nfsd4_bump_seqid, represents the next
 	 * sequence id expected from the client: */
 	atomic_t				so_count;
 	u32					so_seqid;
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux