On Wed, 30 Jul 2014 13:23:12 +0200 Natanael Copa <natanael.copa@xxxxxxxxx> wrote: > Signed-off-by: Natanael Copa <ncopa@xxxxxxxxxxxxxxx> > --- > utils/exportfs/exportfs.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c > index bf07555..7ab93d1 100644 > --- a/utils/exportfs/exportfs.c > +++ b/utils/exportfs/exportfs.c > @@ -12,6 +12,10 @@ > #include <config.h> > #endif > > +#ifndef _GNU_SOURCE > +#define _GNU_SOURCE > +#endif > + > #include <sys/types.h> > #include <sys/stat.h> > #include <sys/vfs.h> These all look really sensible! One small suggestion: it would be really nice to see a comment in the code explaining why _GNU_SOURCE is needed. I suspect such comments get out of date quickly, so maybe it wouldn't end up be all that useful. But having a comment is still, in my opinion, more useful than not. Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
