> +static void nfs4_put_stateowner(struct nfs4_stateowner *sop); Just move the trivial implementation of this one towards the top of the file? > + kfree(oo->oo_owner.so_owner.data); Seems like freeing the owner data should stay in common code instead of the instances. > + void (*so_free)(struct nfs4_stateowner *); This probably should be an ops vector aswell. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html