On Mon, Jul 21, 2014 at 11:02:17AM -0400, Jeff Layton wrote: > Preparation for removal of the client_mutex. Ensure that they are done > while holding the clp->cl_lock. > > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> Looks good, although the orderig vs the earlier patches looks odd to me. I'd introduce the nfs4_put_stid before the locking for the stateid idr, which would then naturally fall into place with the right atomicity. Independent of that: is there any point in keeping the separate remove_stid_locked helper instead of inlining it into the caller? Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
