Re: [PATCH 0/4] nfsd: don't let nfs4_file pin down the inode when it has no open state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 22 Jul 2014 13:51:55 -0400
"J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote:

> On Tue, Jul 22, 2014 at 12:49:40PM -0400, Jeff Layton wrote:
> > This is a port of the patches that Trond sent last night onto the
> > current tip of Bruce's for-3.17 branch. It basically changes how
> > nfs4_file objects are hashed. Instead of using the inode pointer (and
> > pinning down an inode in the process), it uses the filehandle. This
> > allows us to avoid taking an inode reference directly for the nfs4_file.
> > It now only takes them indirectly by virtue of struct file objects in
> > the fi_fds array.
> 
> Looks reasonable on a quick skim.
> 
> It might make sense to get rid of dl_fh at some point?
> 
> --b.
> 

Yeah, I think that should be doable. I'll look at rolling that into the
delegation patches.


> > 
> > If this looks good, I'll resend the unmerged delegation overhaul
> > patches, rebased on top of this series.
> > 
> > Trond Myklebust (4):
> >   nfsd: Store the filehandle with the struct nfs4_file
> >   nfsd: Use the filehandle to look up the struct nfs4_file instead of
> >     inode
> >   nfsd: nfs4_check_fh - make it actually check the filehandle
> >   nfsd: Do not let nfs4_file pin the struct inode
> > 
> >  fs/nfsd/nfs4state.c | 68 +++++++++++++++++++++++++++++++----------------------
> >  fs/nfsd/state.h     |  3 ++-
> >  2 files changed, 42 insertions(+), 29 deletions(-)
> > 
> > -- 
> > 1.9.3
> > 


-- 
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux