On Tue, Jul 15, 2014 at 01:36:14PM -0400, Jeff Layton wrote: > > > > > > + *(__be16 *)(ptr + 2) = (__force __be16)cpu_to_le16(kctx->gk5e->signalg); > > > > This looks silly. This should be: > > > > *(__le16 *)(ptr + 2) = cpu_to_le16(kctx->gk5e->signalg); > > > > Maybe with a comment somewhere explaining why we're doing little endian > > encoding here if it's not obvious from the surrounding code. > > > > The spec doesn't really define these as little-endian values, it's just > an opaque series of bytes that the kernel implementation happens to > handle as little-endian (see RFC 1964, section 1.2.1). Maybe I should > reverse the bytes and we can just make that cpu_to_be16 instead? Sounds okay to me. > So the code is correct, AFAICT -- it's just odd... It might be correct, but with the added cast it's simply too ugly to live. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
