On Mon, 14 Jul 2014 16:23:53 +0200 Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Sunday 13 July 2014 21:57:38 Jeff Layton wrote: > > > > Commit 5b22216e11f7 (nfs: __rcu annotations) added a __rcu annotation to > > the gc_gss_ctx field. I see no rationale for adding that though, as that > > field does not seem to be managed via RCU at all. > > > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: Paul McKenney <paulmck@xxxxxxxxxxxxxxxxxx> > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxxxxxxx> > > Unfortunately, it's been too long ago for me to remember what led to me > adding it. I also don't see a reason for it in today's code, but I don't > know if the code has changed, if I made a mistake then, or if it's actually > needed for some reason I don't see. > Darn, I was hoping you would remember... ;) I don't think the code that manipulates this field has changed substantially since then, but I'm far from certain either. This field does live in a structure that is RCU managed, so maybe that was part of the rationale? In any case, we're just removing the annotation here so this shouldn't materially harm anything, AFAICT. -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
