On Thu, 10 Jul 2014 04:32:49 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > static void nfs4_free_stid(struct kmem_cache *slab, struct nfs4_stid *s) > > @@ -1266,7 +1271,9 @@ free_client(struct nfs4_client *clp) > > rpc_destroy_wait_queue(&clp->cl_cb_waitq); > > free_svc_cred(&clp->cl_cred); > > kfree(clp->cl_name.data); > > + spin_lock(&clp->cl_lock); > > idr_destroy(&clp->cl_stateids); > > + spin_unlock(&clp->cl_lock); > > kfree(clp); > > Taking cl_lock in free_client looks wrong to me, the client shall better be > removed from any data structures that allows looking it up at this > point. > Yeah, ok -- good point. I'll remove that. > Except for that looks good, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
