On Thu, Jul 10, 2014 at 08:19:12AM -0400, Jeff Layton wrote: > > No, the st_deny_bmap does not hold the NFS_SHARE_DENY_* bits > themselves. It sets a bit for each NFS_SHARE_DENY_* mode that the > stateid has used. The difference is subtle, but significant. > > The rationale for that is in the comments above bmap_to_share_mode. Oh, the dangers of the bitshift index access helper confusing the reader. But I think this is only really nessecary because of the odd fi_access semantics, and if we sort that out as suggested by me earlier we can get rid of this confusion as the access/deny checks don't really care about the additional both bit, and once the the O_RDWR file has it's own proper refconting there shouldn't be any need to treat it special. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
