On 07/08/2014 10:33 AM, Steve Dickson wrote:
> When there is no kernel modules loaded the rpc_pipefs
> directory is empty, which cause rpc.gssd to silently
> exit.
>
> This patch adds a check to see if the topdirs_list
> is empty. If so error out without dropping a core.
>
> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
Committed...
steved.
> ---
> utils/gssd/gssd_main_loop.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/utils/gssd/gssd_main_loop.c b/utils/gssd/gssd_main_loop.c
> index 9970028..6946ab6 100644
> --- a/utils/gssd/gssd_main_loop.c
> +++ b/utils/gssd/gssd_main_loop.c
> @@ -173,6 +173,10 @@ topdirs_init_list(void)
> if (ret)
> goto out_err;
> }
> + if (TAILQ_EMPTY(&topdirs_list)) {
> + printerr(0, "ERROR: rpc_pipefs directory '%s' is empty!\n", pipefs_dir);
> + return -1;
> + }
> closedir(pipedir);
> return 0;
> out_err:
> @@ -233,9 +237,10 @@ gssd_run()
> sigaddset(&set, DNOTIFY_SIGNAL);
> sigprocmask(SIG_UNBLOCK, &set, NULL);
>
> - if (topdirs_init_list() != 0)
> - return;
> -
> + if (topdirs_init_list() != 0) {
> + /* Error msg is already printed */
> + exit(1);
> + }
> init_client_list();
>
> printerr(1, "beginning poll\n");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
