Re: [PATCH] nfsd: close potential race between delegation break and laundromat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 07, 2014 at 03:14:50PM -0400, Jeff Layton wrote:
> Sigh...after staring at this patch all day, I think I now see a
> potential problem with the fault injection piece.
> 
> In the "recall" case, we may find a delegation on the cl_delegations
> list that has already been recalled. If that's the case, then we
> probably should just skip it.
> 
> I'll fix this patch, retest and resend. Sorry for the noise...

OK, so sounds like the fix isn't a big deal, but it also sounds like the
fault injection code has come up as needing special attention a few
times during this work now.

Has anyone actually ended up using that code?  Anna?

In retrospect I wonder if it's worth the trouble.  It's very
special-purpose stuff and if nobody's using it then maybe we could just
remove it....

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux