On Mon, 30 Jun 2014 15:32:37 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Mon, Jun 30, 2014 at 08:59:34AM -0400, Jeff Layton wrote: > > On Mon, 30 Jun 2014 05:51:42 -0700 > > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > > I'm pretty happy with what's the first 25 patches in this version > > > with all the review comments addressed, so as far as I'm concerned > > > these are ready for for-next. Does anyone else plan to do a review > > > as well? > > > > > > > Thanks very much for the review so far. > > > > > I'll try to get to the locking changes as well soon, but I've got some > > > work keeping me fairly busy at the moment. I guess it wasn't easily > > > feasible to move the various stateid refcounting to before the major > > > locking changes? > > > > > > > Not really. If I had done the set from scratch I would have probably > > done that instead, but Trond's original had those changes interleaved. > > Separating them would be a lot of work that I'd prefer to avoid. > > > > > Btw, do you have any benchrmarks showing the improvements of the new > > > locking scheme? > > > > No, I'm hoping to get those numbers soon from our QA folks. Most of the > > testing I've done has been for correctness and stability. I'm pretty > > happy with things at that end now, but I don't have any numbers that > > show whether and how much this helps scalability. > > The open-create problem at least shouldn't be hard to confirm. > > It's also the only problem I've actually seen a complaint about--I do > wish it were possible to do just the minimum required to fix that before > doing all the rest. > Yeah, I started writing a testcase that just did a bunch of opens from multiple tasks and timed it, but got sidetracked fixing other bugs in this set. I'll see if I can polish that off and at least get some rough numbers. As far as speeding up opens/creates without touching other stuff...I just don't see how it's possible. It's almost certain that the worst serialization is coming from the client_mutex and I don't see how you'd go about removing it from just that codepath. -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
