On Mon, 30 Jun 2014 04:03:22 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Mon, Jun 30, 2014 at 06:59:13AM -0400, Jeff Layton wrote: > > + /* > > + * For v4.1+ we get the client in the SEQUENCE op. If we don't have one > > + * cached already then we know this is for is for v4.0 and "sessions" > > + * will be false. > > + */ > > + found = find_confirmed_client(clid, false, nn); > > > > FWIW, the main reason for the comment is to explain why we're > > hardcoding the "session" arg to false here instead of using > > cstate->session. > > I'd either just use it to future proof it, or add an assert that it's > really not set.. > An assertion sounds like a good idea. I'll add one in there... -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html