On Sun, 29 Jun 2014 05:16:00 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > +static __be32 lookup_clientid(clientid_t *clid, > > + struct nfsd4_compound_state *cstate, > > + struct nfsd_net *nn); > > This hunk should have been in the previous patch. Or given that > lookup_clientid was mostly rewritten it make sense to just move it to > avoid the forward declaration entirely. > Does it? It's not until this patch that the forward declaration is needed at all. That said, I have a general aversion to forward declarations so moving it up sounds good to me. > Otherwise looks good to me, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
