On Sat, 28 Jun 2014 04:06:42 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > +static void nfsd4_do_callback_rpc(struct work_struct *w) > > nfsd4_run_cb_null? > > > +static void nfsd4_do_cb_recall(struct work_struct *w) > > nfsd4_run_cb_recall? > > > Not entirely sure about the name, but I think they should be: > > a) consistent between the two > b) have somewhat sensible name for the null/probe one > > Otherwise looks good to me, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Those names sound fine to me. I'll change the patch to use them instead. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html