Re: [PATCH v2 010/117] nfsd: Avoid taking state_lock while holding inode lock in nfsd_break_one_deleg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 28 Jun 2014 04:06:42 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> > +static void nfsd4_do_callback_rpc(struct work_struct *w)
> 
> nfsd4_run_cb_null?
> 
> > +static void nfsd4_do_cb_recall(struct work_struct *w)
> 
> nfsd4_run_cb_recall?
> 
> 
> Not entirely sure about the name, but I think they should be:
> 
>  a) consistent between the two
>  b) have somewhat sensible name for the null/probe one
> 
> Otherwise looks good to me,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Those names sound fine to me. I'll change the patch to use them instead.

Thanks,
-- 
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux