On Thu, Jun 19, 2014 at 10:49:18AM -0400, Jeff Layton wrote: > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > Use filp_close() instead of open coding filp_close does more than what's currently opencoded here: - file_count debug check which seems pointless but harmless - calling ->flush. This doesn't do much on nfs exportable filesystem except for exofs, which does dumb shit in it that should be removed, but the maintainer refuse. - call into dnotify, which we probably should be doing here. > -static void __release_lock_stateid(struct nfs4_ol_stateid *stp) > +static void __release_lock_stateid(struct nfs4_lockowner *lo, > + struct nfs4_ol_stateid *stp) But what's the point of explicitly passing the lock owner instead of deriving it? -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
