On Tue, 17 Jun 2014, Trond Myklebust wrote: > On Tue, Jun 17, 2014 at 5:04 PM, Scott Mayhew <smayhew@xxxxxxxxxx> wrote: > > > > I did some more digging and I think I see 2 areas that could be > > improved. > > > > The first would be to clear NFS_INO_INVALID_DATA if we've just > > truncated the inode to 0 bytes -- after all, if we've just unmapped > > all the pages from the inode's address space then isn't our data > > consisitent?: > > What say we rather just don't set/clear NFS_INO_INVALID_DATA if > mapping->nrpages == 0? That should catch the above case, plus a couple > of other potential false positives. > That'd be fine too, but I'm not clear on whether I should do this check for all files or just for regular files (I'm not sure how it would make that big a difference for directory inodes for instance). -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
